P0288R9 move_only_function #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
approved these changes
Oct 8, 2021
JohelEGP
suggested changes
Oct 9, 2021
There was a problem hiding this comment.
https://eel.is/c++draft/func.wrap.general#1 should be pluralized.
jensmaurer
force-pushed
the
motions-2021-10-lwg-6
branch
from
cfb350e
to
ab4511e
Compare
jensmaurer
added
the
changes requested
jensmaurer
force-pushed
the
motions-2021-10-lwg-6
branch
from
0ab6864
to
3ebfcdb
Compare
jensmaurer
removed
the
changes requested
|
@jwakely , please have another look at the latest round of add-on fixes. |
burblebee
added
the
changes requested
This still needs to be done. |
burblebee
requested changes
Oct 16, 2021
burblebee
requested changes
Oct 16, 2021
jensmaurer
force-pushed
the
motions-2021-10-lwg-6
branch
from
85b6cdd
to
c3f23b2
Compare
timsong-cpp
reviewed
Oct 18, 2021
jensmaurer
force-pushed
the
motions-2021-10-lwg-6
branch
2 times, most recently
from
52039a4
to
5ec2bed
Compare
jensmaurer
removed
the
changes requested
|
The most recent commit "[func.wrap.move.ctor] Fix phrasing for move constructor" was discussed here: http://lists.isocpp.org/lib/2021/10/20735.php |
jwakely
reviewed
Oct 18, 2021
burblebee
added
the
changes requested
burblebee
requested changes
Oct 19, 2021
jensmaurer
force-pushed
the
motions-2021-10-lwg-6
branch
from
b1edef0
to
a90506a
Compare
tkoeppe
force-pushed
the
motions-2021-10-lwg-6
branch
from
a90506a
to
e2d31a1
Compare
jensmaurer
removed
the
changes requested
tkoeppe
force-pushed
the
motions-2021-10-lwg-6
branch
from
e2d31a1
to
15a7aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4977
Fixes cplusplus/papers#400
Partially addresses #4960