P1147R1 Printing volatile Pointers #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to [ostream.inserters.arithmetic] and renamed the parameter from 'val' to 'p' for consistency with the 'const void*' overload.
burblebee
reviewed
Oct 16, 2021
| @@ -6419,6 +6420,17 @@ | |||
| \tcode{*this}. | |||
| \end{itemdescr} | |||
|
|
|||
| \indexlibrarymember{operator<<}{basic_ostream}% | |||
| \begin{itemdecl} | |||
| basic_ostream& operator<<(const volatile void* p); | |||
There was a problem hiding this comment.
Shouldn't we use "val" instead of "p" and combine this with the previous itemdecl, similar to how the non-volitile "val" version was?
There was a problem hiding this comment.
We can't combine with the previous \itemdecl, because the \itemdescr is totally different.
"val" is used for the other overloads because these are "arithmetic inserters", but I do believe since we have a separate \itemdecl, we might as well use the more idiomatic "p" for a pointer value.
There was a problem hiding this comment.
It's a bit awkward that the current const void* overload uses p in the header synopsis but val in the description, but regardless, using p in both places for the new overload seems good.
jensmaurer
added
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to [ostream.inserters.arithmetic] and renamed the parameter
from 'val' to 'p' for consistency with the 'const void*' overload.
Fixes #4981
Fixes cplusplus/papers#320