P2077R3 Heterogeneous erasure overloads for associative containers #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burblebee
requested changes
Oct 15, 2021
jensmaurer
added
the
changes requested
jensmaurer
force-pushed
the
motions-2021-10-lwg-13
branch
from
fc0ac38
to
80adf26
Compare
jensmaurer
removed
the
changes requested
burblebee
approved these changes
Oct 19, 2021
tkoeppe
force-pushed
the
motions-2021-10-lwg-13
branch
from
80adf26
to
2ef26a9
Compare
tkoeppe
reviewed
Oct 20, 2021
| \begin{itemize} | ||
| \item \tcode{eq(r1, kx) == eq(kx, r1)}, | ||
| \item \tcode{hf(r1) == hf(kx)} if \tcode{eq(r1, kx)} is \tcode{true}, | ||
| \item \tcode{(eq(r1, kx) \&\& eq(r1, r2)) == eq(r2, kx)}, and |
There was a problem hiding this comment.
Is this condition right? Can't eq(r2, kx) hold, but eq(r1, r2) and eq(r1, rx) could be false?
tkoeppe
force-pushed
the
motions-2021-10-lwg-13
branch
from
2ef26a9
to
d9dfc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4984
Fixes cplusplus/papers#804