New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2321R2 zip #5024
Merged
Merged
P2321R2 zip #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpplearner
reviewed
Oct 13, 2021
timsong-cpp
suggested changes
Oct 14, 2021
jensmaurer
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 14, 2021 19:27
467c2d4
to
c143f15
Compare
jensmaurer
added
the
changes requested
Changes to the wording or approach have been requested and not yet applied.
label
Oct 14, 2021
timsong-cpp
reviewed
Oct 15, 2021
JohelEGP
suggested changes
Oct 15, 2021
jensmaurer
force-pushed
the
motions-2021-10-lwg-16
branch
5 times, most recently
from
October 15, 2021 18:24
7c7d4f3
to
c53ef26
Compare
burblebee
previously requested changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job on the edits, hardly any real errors! amazing!
tkoeppe
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 20, 2021 11:10
c53ef26
to
6ed1b31
Compare
jensmaurer
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 20, 2021 15:43
26a0aec
to
4eb957e
Compare
tkoeppe
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 20, 2021 16:52
4eb957e
to
d0d47c9
Compare
tkoeppe
dismissed
burblebee’s stale review
October 20, 2021 20:42
I think we've actioned everything actionable -- thanks!
Thank you everyone for your amazing work! |
tkoeppe
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 20, 2021 20:47
795fff4
to
263edc2
Compare
- Fix incorrect template-heads for tuple constructors taking a pair. - Rephrased "expression within noexcept" to "exception specification". - Add missing "const" from member function. - Drop "..." from pack (a pack is not the same as a pack expansion).
tkoeppe
force-pushed
the
motions-2021-10-lwg-16
branch
from
October 20, 2021 20:47
263edc2
to
ac52745
Compare
jensmaurer
removed
the
changes requested
Changes to the wording or approach have been requested and not yet applied.
label
Oct 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4987
Fixes cplusplus/papers#1003