Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2321R2 zip #5024

Merged
merged 2 commits into from Oct 20, 2021
Merged

P2321R2 zip #5024

merged 2 commits into from Oct 20, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Oct 13, 2021

  • Fix incorrect template-heads for tuple constructors taking a pair.
  • Rephrased "expression within noexcept" to "exception specification".

Fixes #4987
Fixes cplusplus/papers#1003

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 13, 2021
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 14, 2021
source/utilities.tex Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer force-pushed the motions-2021-10-lwg-16 branch 5 times, most recently from 7c7d4f3 to c53ef26 Compare October 15, 2021 18:24
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on the edits, hardly any real errors! amazing!

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Show resolved Hide resolved
source/ranges.tex Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe dismissed burblebee’s stale review October 20, 2021 20:42

I think we've actioned everything actionable -- thanks!

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 20, 2021

Thank you everyone for your amazing work!

- Fix incorrect template-heads for tuple constructors taking a pair.
- Rephrased "expression within noexcept" to "exception specification".
- Add missing "const" from member function.
- Drop "..." from pack (a pack is not the same as a pack expansion).
@tkoeppe tkoeppe merged commit a8669d8 into main Oct 20, 2021
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 20, 2021
@burblebee burblebee mentioned this pull request Oct 21, 2021
@jensmaurer jensmaurer deleted the motions-2021-10-lwg-16 branch July 29, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2021-10 LWG Motion 16] P2321R2 zip P2321 zip
7 participants