Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2340R1 Clarifying the status of the "C headers" #5025

Merged
merged 2 commits into from Oct 20, 2021
Merged

P2340R1 Clarifying the status of the "C headers" #5025

merged 2 commits into from Oct 20, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 13, 2021
burblebee
burblebee requested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor request, see inline comment

source/support.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed changes requested Changes to the wording or approach have been requested and not yet applied. labels Oct 15, 2021
jensmaurer
jensmaurer commented Oct 20, 2021
View reviewed changes
Copy link
Member Author

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit title
" [diff.mods.to.headers] Delete statement at C headers are deprecated."

at -> that

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 20, 2021

@jensmaurer: Done, thanks!

@tkoeppe tkoeppe merged commit 682525f into main Oct 20, 2021
@jensmaurer jensmaurer deleted the motions-2021-10-lwg-17 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe approved these changes

@JohelEGP JohelEGP JohelEGP left review comments

@Mick235711 Mick235711 Mick235711 left review comments

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
5 participants
@jensmaurer @tkoeppe @burblebee @JohelEGP @Mick235711