Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2450 C++ Standard Library Issues to be moved in Virtual Plenary, Oct. 2021 #5027

Merged
merged 41 commits into from Oct 18, 2021
Merged

P2450 C++ Standard Library Issues to be moved in Virtual Plenary, Oct. 2021 #5027

merged 41 commits into from Oct 18, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Oct 13, 2021 •
edited

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 13, 2021
@jensmaurer jensmaurer force-pushed the motions-2021-10-lwg-1 branch 3 times, most recently from 639512c to c5e4618 Compare October 14, 2021 15:39
@jensmaurer jensmaurer marked this pull request as ready for review October 14, 2021 15:41
@cpplearner
Copy link
Contributor

LWG3498 "Inconsistent noexcept-specifiers for basic_syncbuf" does not remove the noexcept-specifier of the non-member swap in [syncstream.syncbuf.special].

Given that (1) the non-member swap simply calls the member version, and LWG3498 confirms that the member swap is not noexcept, and (2) the non-member swap is not noexcept in the synopsis, could the noexcept in [syncstream.syncbuf.special] be removed editorially (instead of letting LWG3616 go through the whole LWG process)?

timsong-cpp
timsong-cpp suggested changes Oct 14, 2021
View reviewed changes
source/time.tex Outdated Show resolved Hide resolved
source/regex.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/algorithms.tex Outdated Show resolved Hide resolved
source/iostreams.tex Show resolved Hide resolved
source/iostreams.tex Show resolved Hide resolved
source/iterators.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 15, 2021
@jensmaurer
Copy link
Member Author

LWG3498 "Inconsistent noexcept-specifiers for basic_syncbuf" does not remove the noexcept-specifier of the non-member swap in [syncstream.syncbuf.special].

Given that (1) the non-member swap simply calls the member version, and LWG3498 confirms that the member swap is not noexcept, and (2) the non-member swap is not noexcept in the synopsis, could the noexcept in [syncstream.syncbuf.special] be removed editorially (instead of letting LWG3616 go through the whole LWG process)?

Commit added to address this editorially. Notified lwgchair.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 15, 2021
@jensmaurer @tkoeppe
LWG2191 Incorrect specification of match_results(match_results&&)
9a8c274
@jensmaurer @tkoeppe
LWG2381 Inconsistency in parsing floating point numbers
8f7e799
@jensmaurer @tkoeppe
LWG2762 unique_ptr operator*() should be noexcept
4ba323a
@jensmaurer @tkoeppe
LWG3121 tuple constructor constraints for UTypes&&... overloads
11889ea
@jensmaurer @tkoeppe
LWG3123 duration constructor from representation shouldn't be effecti…
a63caa3 
…vely non-throwing
@jensmaurer @tkoeppe
LWG3146 Excessive unwrapping in std::ref/cref
0ecb6bf
@jensmaurer @tkoeppe
LWG3152 common_type and common_reference have flaws in common
3305d6b
@jensmaurer @tkoeppe
LWG3293 move_iterator operator+() has incorrect constraints
83375c3
@jensmaurer @tkoeppe
LWG3361 safe_range<SomeRange&> case
2673e29
@jensmaurer @tkoeppe
LWG3392 ranges::distance() cannot be used on a move-only iterator wit…
318d73f 
…h a sized sentinel
@jensmaurer @tkoeppe
LWG3407 Some problems with the wording changes of P1739R4
5301715
@jensmaurer @tkoeppe
LWG3422 Issues of seed_seq's constructors
2381008
@jensmaurer @tkoeppe
LWG3557 The static_cast expression in convertible_to has the wrong op…
c55739d 
…erand
@jensmaurer @tkoeppe
LWG3559 Semantic requirements of sized_range is circular
0de6ef9
@jensmaurer @tkoeppe
LWG3560 ranges::equal and ranges::is_permutation should short-circuit…
16d32b7 
… for sized_ranges
@jensmaurer @tkoeppe
LWG3561 Issue with internal counter in discard_block_engine
3c71c28
@jensmaurer @tkoeppe
LWG3563 keys_view example is broken
aa550a5
@jensmaurer @tkoeppe
LWG3566 Constraint recursion for operator<=>(optional<T>, U)
28bddb0
@jensmaurer @tkoeppe
LWG3567 Formatting move-only iterators take two
acec76d
@jensmaurer @tkoeppe
LWG3568 basic_istream_view needs to initialize value_
00f0f12
@jensmaurer @tkoeppe
LWG3570 basic_osyncstream::emit should be an unformatted output function
8d003d0
@jensmaurer @tkoeppe
LWG3571 flush_emit should set badbit if the emit call fails
af17c9c
@jensmaurer @tkoeppe
LWG3572 copyable-box should be fully constexpr
fd3c4d0
@jensmaurer @tkoeppe
LWG3573 Missing Throws element for basic_string_view(It begin, End end)
f4b7010
@jensmaurer @tkoeppe
LWG3574 common_iterator should be completely constexpr-able
4087178
@jensmaurer @tkoeppe
LWG3580 iota_view's iterator's binary operator+ should be improved
ba2685a
@jensmaurer @tkoeppe
LWG3581 The range constructor makes basic_string_view not trivially m…
baa3ded 
…ove constructible
@jensmaurer @tkoeppe
LWG3585 Variant converting assignment with immovable alternative
190eb2c
@jensmaurer @tkoeppe
LWG3589 The const lvalue reference overload of get for subrange does …
9d1ebed 
…not constrain I to be copyable when N == 0
@jensmaurer @tkoeppe
LWG3590 split_view::base() const & is overconstrained
7ab5450
@jensmaurer @tkoeppe
LWG3591 lazy_split_view<input_view>::inner-iterator::base() && invali…
4612189 
…dates outer iterators
@jensmaurer @tkoeppe
LWG3592 lazy_split_view needs to check the simpleness of Pattern
d5ce7d3
@jensmaurer @tkoeppe
LWG3593 Several iterators' base() const & and lazy_split_view::outer-…
661e086 
…iterator::value_type::end() missing noexcept
@jensmaurer @tkoeppe
LWG3595 Exposition-only classes proxy and postfix-proxy for common_it…
de05348 
…erator should be fully constexpr
@jensmaurer @tkoeppe
[range.take.overview] Avoid highlighting single evaluation of "F"
e0f11a3 
"F" appears only once in the expression, so there is no implication
it might be evaluated multiple times.

Introduced by LWG3407.
@jensmaurer @tkoeppe
[syncstream.syncbuf.special] Remove 'noexcept' for non-member swap
8753efa 
LWG3498 confirmed that basic_syncbuf's member swap is not 'noexcept'.
Since the non-member swap simply delegates to the member swap,
the former can't be 'noexcept', either.
@tkoeppe tkoeppe merged commit d027b53 into main Oct 18, 2021
@frederick-vs-ja frederick-vs-ja mentioned this pull request Oct 19, 2021
Closed
@jensmaurer jensmaurer deleted the motions-2021-10-lwg-1 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@timsong-cpp timsong-cpp timsong-cpp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
4 participants
@jensmaurer @cpplearner @tkoeppe @timsong-cpp