Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c.mb.wcs] mbrtoc8 stores code units, not characters #5054

Merged
merged 1 commit into from Nov 23, 2021
Merged

[c.mb.wcs] mbrtoc8 stores code units, not characters #5054

merged 1 commit into from Nov 23, 2021

Conversation

jensmaurer
Copy link
Member

Fixes #5001

@jensmaurer
Copy link
Member Author

@hubert-reinterpretcast , please have a look.

hubert-reinterpretcast
hubert-reinterpretcast approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@tkoeppe tkoeppe merged commit 5475bda into cplusplus:main Nov 23, 2021
@jensmaurer jensmaurer deleted the c36 branch November 23, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubert-reinterpretcast hubert-reinterpretcast hubert-reinterpretcast approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[c.mb.wcs] mbrtoc8 should generally be said to store code units
3 participants
@jensmaurer @hubert-reinterpretcast @tkoeppe