Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.view] Move note outside of list. #5064

Merged
merged 1 commit into from Oct 22, 2021
Merged

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Oct 22, 2021

Also replace "and/or" by just "/", which already means "and/or".

@jwakely
Copy link
Member

jwakely commented Oct 22, 2021

I'm a little uneasy about the copies/moves change. Core wording talks about "copy/move constructors" and it means one or the other, as appropriate to the context. Here we are talking about a possible mix of both, e.g. N/2 copies and N/2 moves. I can read the proposed change as new meaning N copies or N moves, but not a mix.

But maybe I'm being too picky.

@jwakely
Copy link
Member

jwakely commented Oct 22, 2021

Moving the note looks good though

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moved note is fine; the other change not so much.

source/ranges.tex Outdated Show resolved Hide resolved
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most wonderful.

@tkoeppe tkoeppe merged commit 65ec10a into cplusplus:main Oct 22, 2021
@tkoeppe tkoeppe deleted the notelist branch October 22, 2021 23:20
Copy link

@Flexiproof Flexiproof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants