Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpp.replace.general] Rephrase function-like macro invocations #5065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cpp.replace.general] Rephrase function-like macro invocations #5065

wants to merge 1 commit into from

Conversation

jensmaurer
Copy link
Member

Fixes #5022

@tkoeppe tkoeppe requested a review from zygoloid October 22, 2021 23:22
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 22, 2021 •
edited

@zygoloid: could you perhaps take a look when you get a chance? We should probably run this by CWG and SG22 eventually (though we can also wait for WG14 to finish their review of the __VA_OPT__ proposal first).

@jensmaurer jensmaurer added the cwg Issue must be reviewed by CWG. label Oct 23, 2021
@jensmaurer
[cpp.replace.general] Rephrase function-like macro invocations
fe4c33a 
using the new grammar non-terminal pp-balanced-token-seq.
@jensmaurer
Copy link
Member Author

(Updated VA_OPT replacement rules to reflect pp-balanced-token-seq.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
cwg Issue must be reviewed by CWG.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider introducing a new grammar pp-balanced-token-seq
2 participants
@jensmaurer @tkoeppe