Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.start.main] remove redundant phrase #5083

Merged
merged 2 commits into from Nov 23, 2021
Merged

Conversation

timsong-cpp
Copy link
Contributor

If "to end the program" is merely describing what std::exit does, it's redundant; if it is read as expressing purpose or intent, it's incorrect - whether a program has UB cannot depend on the programmer's intent.

source/basic.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 23, 2021
@jensmaurer
Copy link
Member

@timsong-cpp , generally agreed. Could you please apply the "called" -> "invoked" drive-by fix? ("Called" is ambiguous and could mean "named" or "termed": "I call my son Richard", with no connection to function calls.)

Co-authored-by: languagelawyer <38548419+languagelawyer@users.noreply.github.com>
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 23, 2021
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @tkoeppe , please squash when merging.

@tkoeppe tkoeppe merged commit c193550 into cplusplus:main Nov 23, 2021
@timsong-cpp timsong-cpp deleted the patch-3 branch November 24, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants