New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp.cond,cpp.predefined,version.syn] Highlight preprocessor dates #5125
Comments
Probably not. |
Sorry, this was ambiguous: I was specifically referring to the "grey month" version. We should form a wider consensus whether we want any color-based highlighting here at all. |
I don't think the colors I chose do the proposal any justice. They look like hyperlinks, one unused and one used. Using bold didn't help; the code hardly looked any different. |
My suggestions are a bit hideous. It'd be better to base the issue's resolution by referencing existing documents. This is probably clash with general code highlighting anyways. |
I have previously prepared a PR that I did not push, where I used digit separators for all the long literals in the standard. In that case, these macros were rendered as: Is that something I should consider submitting instead? The main intent in that PR was making the large numbers specified in the random numbers clause more readable. |
No, see:
|
Editorial meeting decision: we prefer if we added digit separators, and that is an observable change that requires a (small) paper (with an Annex C change). Such a paper is warmly invited. |
This comment was marked as resolved.
This comment was marked as resolved.
Why? The preprocessor understands digit separators and they don't affect the value. |
You're right: https://compiler-explorer.com/z/ozK9xE5qs! |
The breaking change is that stringification observes the change. |
This is a follow up for #5109. Code highlighting has been previously discussed at #572.
I have a working example at https://github.com/JohelEGP/draft/tree/highlight_cpp_dates that looks like this:
The text was updated successfully, but these errors were encountered: