[dcl.meaning.general] Clarify correspondence for block-scope friends #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@opensdh, see the linked issue. This fix seems obvious and desirable. Please have a look. |
opensdh
approved these changes
Dec 16, 2021
| @@ -2548,7 +2548,7 @@ | |||
| Otherwise, the terminal name of $E$ is not looked up. | |||
| The declaration's target scope is the innermost enclosing namespace scope; | |||
| if the declaration is contained by a block scope, | |||
| the declaration shall correspond to a declaration | |||
| the declaration shall correspond to a reachable\iref{module.reach} declaration | |||
There was a problem hiding this comment.
Or just use English "an earlier", since we can't need to look into other translation units as for "precedes" or "reachable".
There was a problem hiding this comment.
Uh, but "earlier" also has a temporal meaning, which we don't want here.
There was a problem hiding this comment.
There is no time to apply here (although my initial mistake was more or less supposing that there was).
There was a problem hiding this comment.
Exactly, and that's why I don't want "earlier", which has a temporal aspect. In contrast, "reachable" has positional meaning (only), not temporal.
|
@tkoeppe , this looks ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5148