Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std] Extend \iref to accept a list of cross-references #5151

Merged
merged 2 commits into from Feb 22, 2022

Conversation

jensmaurer
Copy link
Member

No description provided.

@jensmaurer
Copy link
Member Author

jensmaurer commented Dec 15, 2021

@tkoeppe , please have a look. This is for consistent application of \iref even with multiple cross-references.

The patch is a visual no-op except for a few situations where a linebreak now happens elsewhere (because breaking before "(" is now discouraged) or where whitespace is different because ~ got turned into a normal space. The former doesn't apply extra spacing after (end-of-sentence) periods.

@jensmaurer jensmaurer changed the title [std] Extend \\iref to accept a list of cross-references [std] Extend \iref to accept a list of cross-references Dec 16, 2021
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jan 19, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jan 19, 2022
@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 21, 2022

The effect looks good, but I worry a little bit about creating some excessively complex implementation. Do you think this feature is worth the price?

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
@jensmaurer
Copy link
Member Author

Which price? This seems pretty straightforward in LaTeX3 terms.

Plus we get the benefit that we have a consistent handling linebreaks / spacing with xrefs for both "(1.2.3)" and "(1.2.3, 4.5.6)" cases.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
@jensmaurer
Copy link
Member Author

@tkoeppe, rebased

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 22, 2022

OK. I've caught up on the history of LaTeX3 (it's come quite some way since I last followed it), and it seems that what you're doing here is at least somewhat normal and stable, and there's no reason to not use those new features.

Feel free to rebase and merge!

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 22, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants