Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[temp.dep.general] p2.1 lacks a trialing 'or' #5186

Merged
merged 1 commit into from Jan 22, 2022

Conversation

ChuanqiXu9
Copy link
Contributor

[temp.dep.general]p2.1: http://eel.is/c++draft/temp.dep.general lacks a trailing or, which makes it a little bit confusing at the first sight.

@jwakely
Copy link
Member

jwakely commented Jan 6, 2022

This changes "x, y, or z" into "x, or y, or z" which doesn't seem like an improvement. The conjunction is only needed before the last term.

@jwakely
Copy link
Member

jwakely commented Jan 6, 2022

Although since this is formatted as an itemized list, not just "x, y, or z" maybe it does help.

@ChuanqiXu9
Copy link
Contributor Author

It looks like not consistency with other part. The p2.4 in the same page is an example: http://eel.is/c++draft/temp.dep.general#2.4.

@jensmaurer
Copy link
Member

We are generally inconsistent with the placement of "and" and "or" in itemized lists. We have lots of examples where we do "x, y, or z" and we also have examples where we do "x, or y, or z".

We should decide what we want to do here and document that on the wiki for future incremental harmonization.

Suggestion: Prefer "x, y, or z" for itemized lists unless the individual items are so huge (e.g. because of sub-bullets) that the context might get lost.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 6, 2022
@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 22, 2022
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but can we change the commit message to "trailing"

@jensmaurer
Copy link
Member

Of course.

@jensmaurer jensmaurer merged commit 3cb2ee9 into cplusplus:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants