Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macros] Introduce 'term.*' labels #5210

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jensmaurer
Copy link
Member

No description provided.

@jensmaurer
Copy link
Member Author

jensmaurer commented Jan 18, 2022

@tkoeppe, this introduces \termref to refer to a defined term. Furthermore, all \defn terms automatically get a term.* label assigned. As an added bonus, you get a PDF hyperref for \termref, which takes you directly to the right page in the PDF (not to the start of the section, it seems):

termref

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 18, 2022

Is it the future already?!

source/basic.tex Outdated
@@ -5061,7 +5062,7 @@
on the access to these entities\iref{class.access};

\item
\defnx{unions}{\idxcode{union}}, which are classes capable of containing objects of
\textit{unions}, which are classes capable of containing objects of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a bare \textit in the main document?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because everything else in this itemized list is italicized, and other bullets claim to contain definitions, but this one (and likely the other bullets, too) are not actually definitions. I wanted to keep the local italics consistency. If you think otherwise, I'll just remove the italics here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use \emph then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jensmaurer
Copy link
Member Author

@Eelis , this might also interest your HTML conversion if/when it lands.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 19, 2022
@jensmaurer
Copy link
Member Author

jensmaurer commented Jan 21, 2022

Editorial meeting 2022-01-21: Generally in favor. To be applied after the clause reorganization #5124. Also globally replace \defn with \termdef (also related macros). The latter makes the change global and conflict-prone, so needs close coordination with @tkoeppe.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 21, 2022
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 21, 2022
Comment on lines -5071 to +5075
\defnx{unions}{\idxcode{union}}, which are classes capable of containing objects of
\emph{unions}, which are classes capable of containing objects of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loses the index entry. Is that deliberate (since it's not really a definition)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Most of the stuff here is not really a definition and should be cleaned up eventually. The current stage just removes the one conflict that was flagged by LaTeX.

For two partial specializations,
the first is \defn{more specialized} than the second if, given the following
the first is \defnx{more specialized}{more specialized!class template} than the second if, given the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're moving this: variable templates can be more specialized too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, moving that under "class template" is not good; we should keep it generic, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And function templates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function templates can't be partially specialized.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index entry already said !class template because the whole partial-specialization section used to assume it was a class template. I'm just pointing out that a line you're touching is (and already was) outdated.

Function templates can be more specialized, but they're not relevant here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence starts with "For two partial specialization,.."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 22, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Feb 22, 2022
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 2, 2022
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 2, 2022
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants