Typographic fixes, spacing after \opt #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stbergmann: Could you please rebase this? |
* occurrences of "\opt \terminal{" apparently always require "\opt{}" to not eat
the intervening space (despite the \xspace in the definition of \opt)
* cleaned up two occurrences of "\opt\ " (in
noptr-abstract-pack-declarator \terminal{[} constant-expression\opt\ \terminal{]} attribute-specifier-seq\opt\br
in declarators.tex and grammar.tex) to consistenly use "\opt{}" instead
* cleaned up two occurrences of "\opt{}" (in
pp-tokens\opt{} new-line
in grammar.tex and preprocessor.tex) that did not need the "{}"
stbergmann
force-pushed
the
space-after-opt
branch
from
a832346
to
ab47599
Compare
|
@tkoeppe, "git push -f"-ed the rebase onto stbergmann:space-after-opt now, hope that's the intended way to rebase this pull request. |
|
Yes, great, thanks. @zygoloid: Could you please take a look? |
zygoloid
added a commit
that referenced
this pull request
Mar 7, 2016
[gram] Fix lack of space after [opt] in some grammar productions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
occurrences of "\opt \terminal{" apparently always require "\opt{}" to not eat
the intervening space (despite the \xspace in the definition of \opt)
cleaned up two occurrences of "\opt\ " (in
noptr-abstract-pack-declarator \terminal{[} constant-expression\opt\ \terminal{]} attribute-specifier-seq\opt\br
in declarators.tex and grammar.tex) to consistenly use "\opt{}" instead
cleaned up two occurrences of "\opt{}" (in
pp-tokens\opt{} new-line
in grammar.tex and preprocessor.tex) that did not need the "{}"