New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[std] Replace hyphen with period in labels #5227
Conversation
@zygoloid, at your service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like it.
@tkoeppe How do you feel about requiring labels to match /[0-9a-z.]*/
?
Are you referring to (visible) stable labels or to the internal term labels? |
@tkoeppe, this issue is dealing with (visible) stable section labels, only. So, the question is: Are you fine with hard-limiting (visible) stable section to match |
I'm not fully convinced byt the resulting restrictions, since this forces us to conflate mere compound words with the hierarchical use of dots, e.g. Practically, though, a) this particular change is very small and I have no issue with the handful of labels touched here, and b) we (or at least Jens's script) already seem to be claiming that the existing use of hyphens is "bad", so it seems like we already made that decision. Also c) the existing use of stable labels is already full of historic ad-hoc ballast, so it may not be terribly useful to try and find any patterns in the labels anyway. So consider this a non-enthusiastic approval. |
This needs a rebase, though. |
@tkoeppe, I guess you'll merge this, then. |
and add a check.
and add a check.
Fixes #5225