Fix order of std-format-spec field descriptions. #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
added
the
needs rebase
|
Could you please rebase this? |
Moves the wording describing the zero-padding before the description of the width; matching the order of the fields in the std-format-spec. The swapped order was introduced in the initial <format> paper P0645R10 Text formatting Since both fields had one paragraph description it wasn't too noticeable. P1868R2 馃 width: clarifying units of width and precision in std::format expanded the wording of the width. Now it's not so easy to find the description of the zero-padding field.
mordante
force-pushed
the
move_zero_padding
branch
from
e38fb1e
to
ecacf05
Compare
tkoeppe
removed
the
needs rebase
|
@jwakely, @CaseyCarter: thoughts on this swap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the wording describing the zero-padding before the description of
the width; matching the order of the fields in the std-format-spec.
The swapped order was introduced in the initial paper
P0645R10 Text formatting
Since both fields had one paragraph description it wasn't too noticeable.
P1868R2 馃 width: clarifying units of width and precision in std::format
expanded the wording of the width. Now it's not so easy to find the
description of the zero-padding field.