P2442R1 Windowing range adaptors: views::chunk and views::slide #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Feb 5, 2022
There was a problem hiding this comment.
slide_view's begin and end have descriptions like:
Returns:
- If cond,
a. - Otherwise,
b.
IIRC, they are done like this in <algorithm>:
Returns:
- If cond, returns
a. - Otherwise, returns
b.
The latter is certainly clearer. Is this worth pursuing (at this time or otherwise)?
Also applies to https://github.com/cplusplus/draft/pull/5249/files#diff-015716b0f124dba6acb7cdf24285de5d954d0958ca8abbb2ad82a015d1852a9eR11489-R11493 and https://github.com/cplusplus/draft/pull/5249/files#diff-015716b0f124dba6acb7cdf24285de5d954d0958ca8abbb2ad82a015d1852a9eR11592-R11595.
jensmaurer
force-pushed
the
motions-2022-02-lwg-12
branch
3 times, most recently
from
0351517
to
c06b69a
Compare
|
Thanks for all the fixes! |
tkoeppe
force-pushed
the
motions-2022-02-lwg-12
branch
2 times, most recently
from
3d4ae2a
to
dbc0e91
Compare
- Fix return type in description of chunk_view::inner-iterator::operator++. - Add reference to last_ele_ for ambiguous "if present" phrases
tkoeppe
force-pushed
the
motions-2022-02-lwg-12
branch
from
dbc0e91
to
4b1c80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5271
Fixes cplusplus/papers#1108