New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1206R7 Conversions from ranges to containers #5280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Result:\s end in a period, others do not. I don't remember the direction taken in #4460 for that, if any.
aab5bcd
to
ddb2fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5280 (comment) says
The incoming paper uses "is" for the new text. Further, we gravitate towards "shall" being used for diagnosable requirements on user code, which this is not. Not changing.
Here I suggest to change back "is" from the paper that were changed to "shall be" during its transcription. Along with one from the surrounding diff context that shows its inconsistent application.
8cd3b52
to
aba6417
Compare
aba6417
to
5768ce4
Compare
- Fix misnamed constructor in [multiset.cons] - Fix garbled constructor in [stack.defn] - Fix bad pack expansion "std::forward<Args...>(args)..."
5768ce4
to
6d4a94f
Compare
Fixes #5264
Fixes cplusplus/papers#145