[module.interface] Add adjective 'exported' to dangling prons #5290
Conversation
|
@opensdh, this looks like a minor improvement to me. What do you think? |
I'd say it should just be "If an exported declaration…", since we're not trying to key off any previous mention with this approach. (My only "relevance" to this wording is that my (unreviewed) CWG2443 wording makes the same change to /3.) |
jensmaurer
added
the
changes requested
jensmaurer
removed
the
changes requested
|
@opensdh, if you could be so kind and hit "approve" on this pull request, in case you like it. |
|
Using two commits to change two words makes me sad, but the (net) change is correct. |
|
I expect these commits will be squashed eventually. It's just when you edit a PR on GitHub, you get extra commits. |
|
Sorry, I should have known that from previous pull requests. My comment was a leak from other projects where people have to be prodded into doing such things even when they're "obviously correct". |
|
@tkoeppe, on your plate now. Tagged with milestone post-2022-02 so that we won't forget. Please squash and fix commit description when merging. |
|
Thanks! I have squashed them. |
Although we could infer the declaration should refer to 'exported declaration' from the context in the previous paragraph, they are two paragraphs and split by a relatively long example. So I am confused at the first sight. I think it would be helpful to add the adjective.