Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lex.name] prohibits uses of predefined macro names and feature-test macros CWG 2818 #5296

Open
JohelEGP opened this issue Feb 15, 2022 · 4 comments
Open

[lex.name] prohibits uses of predefined macro names and feature-test macros CWG 2818 #5296

JohelEGP opened this issue Feb 15, 2022 · 4 comments

Comments

@JohelEGP
Copy link
Contributor

This seems to prohibit uses of predefined macro names and library feature-test macros.

3# In addition, some identifiers are reserved for use by C++ implementations and shall not be used otherwise; no diagnostic is required.
(3.1) Each identifier that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use.
(3.2) Each identifier that begins with an underscore is reserved to the implementation for use as a name in the global namespace.

More formally, according to [intro.compliance.general],

(2.3)
If a program contains a violation of a rule for which no diagnostic is required, this document places no requirement on implementations with respect to that program.

Permission to use predefined macro names and library feature-test macros needs to be added to [cpp.predefined] and [version.syn], respectively. For full effect, amend [lex.name]p3's "otherwise" to "unless otherwise specified".
@JohelEGP
Copy link
Contributor Author

I think the permission added to [version.syn] will also need something like [cpp.predefined]'s p4, that is, that a library feature-test macro is not subject of #define and #undef. But that is not relevant to the issue at hand.

@frederick-vs-ja
Copy link
Contributor

IIUC this issue touches the same area as #5187.
In addition to the standard, implementations generally provide their own feature test macros. I think we should (conditionally) allow usage of these macros.

@JohelEGP
Copy link
Contributor Author

JohelEGP commented Feb 16, 2022 •
edited

IIUC this issue touches the same area as #5187.

Indeed.

In addition to the standard, implementations generally provide their own feature test macros. I think we should (conditionally) allow usage of these macros.

I had considered this. But my conclusion was that implementations can define that so as not to fall under the standard's NDR. They probably already do that with __is_same and family.

@opensdh
Copy link
Contributor

opensdh commented Apr 6, 2022

It's my intent to resolve this along with #5187.

@frederick-vs-ja frederick-vs-ja mentioned this issue Jan 18, 2023
Open
@JohelEGP JohelEGP changed the title [lex.name] prohibits uses of predefined macro names and feature-test macros [lex.name] prohibits uses of predefined macro names and feature-test macros CWG2818 Nov 12, 2023
@JohelEGP JohelEGP changed the title [lex.name] prohibits uses of predefined macro names and feature-test macros CWG2818 [lex.name] prohibits uses of predefined macro names and feature-test macros CWG 2818 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohelEGP @frederick-vs-ja @opensdh