[diff.cpp11] Supply a compatibility note for CWG1560 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please squash and rebase the commits? |
k-satoda
force-pushed
the
diff.cpp11-for-cwg1560
branch
from
bfeb14e
to
234fa2e
Compare
|
OK. Squeshed and rebased. |
|
@zygoloid: Could you please take a look? |
|
As an April 2013 DR, doesn't it technically amend C++11? |
|
@cubbimew Yes it amends C++11. But the way is not perfectly compatible. |
| @@ -1380,6 +1380,40 @@ | |||
| Note that this might occur when the lvalue has a type given by a template | |||
| parameter. | |||
|
|
|||
| \rSec2[diff.cpp11.expr]{Clause \ref{expr}: expressions} | |||
There was a problem hiding this comment.
Please delete this header; it is a duplicate of the one on line 1372.
k-satoda
force-pushed
the
diff.cpp11-for-cwg1560
branch
from
234fa2e
to
802f88e
Compare
|
Thank you for the review. I made the fixes, and squashed and rebased again. |
|
Can you please rebase? |
CWG1560: Gratuitous lvalue-to-rvalue conversion in conditional-expression with throw-expression operand http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1560 The change had been made between C++11 and C++14.
k-satoda
force-pushed
the
diff.cpp11-for-cwg1560
branch
from
802f88e
to
0a65969
Compare
|
OK. Rebased. |
|
@zygoloid: PTAL |
FrankHB
pushed a commit
to FrankHB/draft
that referenced
this pull request
Jul 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWG1560: Gratuitous lvalue-to-rvalue conversion in
conditional-expression with throw-expression operand
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1560
The change had been made between C++11 and C++14.