Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[allocator.requirements.general] Dismantle requirements table #5327

Merged
merged 3 commits into from Mar 17, 2022
Merged

[allocator.requirements.general] Dismantle requirements table #5327

merged 3 commits into from Mar 17, 2022

Conversation

jensmaurer
Copy link
Member

Fixed #5310

@jensmaurer
Copy link
Member Author

@tkoeppe, here you are. You can cherry-pick only the first commit if you don't want the whole thing.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 28, 2022

Wonderful, thanks!

@jwakely, @CaseyCarter: would you perhaps be able to take a look at this requirements table replacement? Do you think it needs LWG oversight?

JohelEGP
JohelEGP suggested changes Feb 28, 2022
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Show resolved Hide resolved
source/lib-intro.tex Show resolved Hide resolved
source/lib-intro.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

@JohelEGP , thanks for the review. All trivial fixes are applied.

jwakely
jwakely approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs review/approval from LWG. There is unanimous support for these changes among LWG telecon attendees.

If some minor problems do get introduced by this change, they can be fixed later. We don't need to hold the change back waiting for LWG review.

This was referenced Mar 17, 2022
Open
Open
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2022

Thanks, @jwakely! Merging; please get in touch if there are any complaints or issues.

@tkoeppe tkoeppe merged commit 4e4aa46 into cplusplus:main Mar 17, 2022
@jensmaurer jensmaurer deleted the c4 branch March 17, 2022 17:36
@tkoeppe tkoeppe mentioned this pull request Nov 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jensmaurer @tkoeppe @jwakely @JohelEGP