[range.utility.conv.general] Add missing template parameter to container_inserter #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewillk
changed the title
|
Any comments? |
|
The words in P1206R7 Conversions from ranges to containers were correctly applied, so this was a bug in the incoming paper. Given the usage, this change looks plausible. @jwakely , @CaseyCarter , @ericniebler , @cor3ntin : Please offer an opinion. |
jensmaurer
approved these changes
Mar 22, 2022
jwakely
approved these changes
Mar 22, 2022
|
Looks good to me. |
CaseyCarter
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I strongly doubt that this should be a
constexprfunction, if so I'd be happy to add an LWG (if that can't be as an edit fixed) for it.