Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2071R2 Named universal character escapes #5368

Closed
wants to merge 1 commit into from

Conversation

steve-downey
Copy link

@steve-downey steve-downey commented Mar 26, 2022

The wording as approved by CWG for P2071, including the control code alias table which would be tedious to reproduce. Uses a new code font macro for uname to clarify there is no internal invisible whitespace.

Fixes cplusplus/papers#798

@steve-downey
Copy link
Author

Pending plenary approval, of course.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to [cpp.predefined] is missing.

I'm totally fine if you don't want to continue working on this, in which case I'm going to take it over; thanks for the submission regardless.

source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/macros.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member

Also, please rebase on HEAD, squash the fixes, and force-push. Thanks.

@jensmaurer jensmaurer added this to the post-2022-07 milestone Mar 26, 2022
@steve-downey
Copy link
Author

I'd like to complete this. It seems like a useful skill to learn for the committee and an additional way to contribute. Although I understand I may be making additional work for reviewers while I'm learning.

I'll push all the requested updates to this soon, rebased against current HEAD.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next round.

Feel free to squash and force-push.

Please also clean up the commit description; it should just be
P2071R2 Named universal character escapes

All the incremental updates done during this conversation are not relevant long-term.

source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
@steve-downey steve-downey changed the title P2071 Named universal character escapes P2071R2 Named universal character escapes Mar 30, 2022
@steve-downey steve-downey force-pushed the named-unicode branch 2 times, most recently from 739a384 to b0fabc6 Compare March 30, 2022 03:55
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's progress. One issue remains.

source/lex.tex Outdated Show resolved Hide resolved
@steve-downey steve-downey force-pushed the named-unicode branch 2 times, most recently from 7e6c8fb to 79cb4c9 Compare April 1, 2022 02:26
@steve-downey
Copy link
Author

I apologize for the extra work. Let me know if there's more to do.

@jensmaurer
Copy link
Member

Thanks for looking after this. This looks good to me now.

source/preprocessor.tex Outdated Show resolved Hide resolved
Wording for the paper P2071R2 Named universal character escapes, actually an
alternate form of universal-character-name, as reviewed and approved by
CWG. Not yet approved by plenary.
@jensmaurer
Copy link
Member

Thanks, we're through. I'm not going to "Approve" this before the plenary motion for fear of someone accidentally merging this.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 5, 2022

Thank you so much for doing this work, I'm very sorry we didn't keep track of it better!

@tkoeppe tkoeppe closed this Aug 5, 2022
@steve-downey
Copy link
Author

steve-downey commented Aug 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2071 Named universal character escapes
3 participants