Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stacktrace.syn] Add '#include <compare>' #5374

Merged
merged 1 commit into from Apr 1, 2022
Merged

[stacktrace.syn] Add '#include <compare>' #5374

merged 1 commit into from Apr 1, 2022

Conversation

jensmaurer
Copy link
Member

LWG3330 added #include to all header files
where a three-way comparison operator was declared,
but missed this one.

Fixes #5373

@jensmaurer
[stacktrace.syn] Add '#include <compare>'
3c55c62 
LWG3330 added #include <compare> to all header files
where a three-way comparison operator was declared,
but missed this one.
@jensmaurer
Copy link
Member Author

@jwakely, @CaseyCarter, is this sufficiently editorial given the intent of LWG3330 ?

jwakely
jwakely approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to consider this editorial, yes.

@jensmaurer
Copy link
Member Author

@tkoeppe, you're next.

@tkoeppe tkoeppe merged commit 4813f20 into cplusplus:main Apr 1, 2022
@jensmaurer jensmaurer deleted the c2 branch April 1, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jwakely jwakely jwakely approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stacktrace.syn] should depict <stacktrace> including <compare>
4 participants
@jensmaurer @CaseyCarter @jwakely @tkoeppe