Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alg.min.max] hasn't been updated when LWG3180 has been applied #5375

Closed
philnik777 opened this issue Mar 31, 2022 · 1 comment · Fixed by #5376
Closed

[alg.min.max] hasn't been updated when LWG3180 has been applied #5375

philnik777 opened this issue Mar 31, 2022 · 1 comment · Fixed by #5376

Comments

@philnik777
Copy link

LWG3180 states that [alg.min.max] should be updated to reflect the changes in [algorithm.syn].
The declarations of ranges::minmax_element in [alg.min.max] should be:

template<forward_­iterator I, sentinel_­for<I> S, class Proj = identity,
         indirect_­strict_­weak_­order<projected<I, Proj>> Comp = ranges::less>
  constexpr ranges::minmax_element_result<I>
    ranges::minmax_element(I first, S last, Comp comp = {}, Proj proj = {});
template<forward_­range R, class Proj = identity,
         indirect_­strict_­weak_­order<projected<iterator_t<R>, Proj>> Comp = ranges::less>
  constexpr ranges::minmax_element_result<borrowed_iterator_t<R>>
    ranges::minmax_element(R&& r, Comp comp = {}, Proj proj = {});
@frederick-vs-ja frederick-vs-ja mentioned this issue Mar 31, 2022
Merged
@jwakely
Copy link
Member

jwakely commented Mar 31, 2022

LWG3180 was applied in e33be08 but was incomplete, as it missed the "and adjust the declarations of std::ranges::minmax_element in 27.8.9 [alg.min.max] to agree" part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jwakely @philnik777