[iterator.concept.readable] remove obsolete Note #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a note in this section > The expression *i is indirectly required to be valid via the exposition-only dereferenceable concept This makes sense before P1878R1. But after P1878R1, the expression `*i` is "directly" required in the requires clause. So this note is no longer valid.
jensmaurer
approved these changes
Apr 24, 2022
|
@CaseyCarter , @jwakely , would you agree? |
CaseyCarter
approved these changes
Apr 26, 2022
Absolutely. This note is just confusing now. |
jwakely
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a note in this section
This makes sense before P1878R1. But after P1878R1, the expression
*iis "directly" required in the requires clause. So this note is no longer
valid.
The change that adds
*iin the require clause is here333b6eb#diff-0043c904d3e034a77b44feeddf18719e63e646d55db1c564f2a5defe7330c9eaR1213