[except.pre] Reword "shall not be used to" avoiding question of actual "use" #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Apr 25, 2022
hubert-reinterpretcast
force-pushed
the
fix_used_to_jump
branch
from
72ab267
to
c19b51f
Compare
JohelEGP
suggested changes
Apr 27, 2022
…l "use" The "shall not be used to" phrasing may be taken to refer only in cases where the actual use occurs or is the primary intent. Instead, the intended restriction can be written in terms of static properties of the constructs so restricted in the style of [stmt.if]. A new term of art (control-flow-limited statement) is introduced in [stmt.label] to express the restrictions. Both [stmt.if] and [except.pre] are updated to use the new term. Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
hubert-reinterpretcast
force-pushed
the
fix_used_to_jump
branch
from
aa3db9e
to
05b3844
Compare
zygoloid
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
This looks like a nice improvement to me.
I briefly considered whether it'd be useful to say that the body of a function is also control-flow-limited, but that doesn't seem to really allow any further simplifications. (We could maybe delete the second sentence of [stmt.goto]/1, but that seems to be about it.)
|
@tkoeppe , any final thoughts before I merge this? |
|
@jensmaurer: no, this does look like a nice improvement. As long as you're CWG-happy with inventing new terms editorially here, please do feel free to merge. (Maybe CWG should be informed that we have a new term at some point? Then again, control flow is not something that we touch a lot.) |
tkoeppe
reviewed
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "shall not be used to" phrasing may be taken to refer only in cases
where the actual use occurs or is the primary intent. Instead, the
intended restriction can be written in terms of static properties of the
constructs so restricted in the style of [stmt.if].
A new term of art (control-flow-limited statement) is introduced in
[stmt.label] to express the restrictions. Both [stmt.if] and
[except.pre] are updated to use the new term.
Co-authored-by: Johel Ernesto Guerrero Peña johelegp@gmail.com