Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cons.slice] Add copy constructor for 'slice' to synopsis #5444

Merged
merged 1 commit into from May 4, 2022
Merged

[cons.slice] Add copy constructor for 'slice' to synopsis #5444

merged 1 commit into from May 4, 2022

Conversation

jensmaurer
Copy link
Member

Fixes #5429

@jensmaurer
Copy link
Member Author

jensmaurer commented May 4, 2022 •
edited

(I'm not sure whether adding the copy constructor to the class synopsis is the right call, or just removing the copy constructor from the itemdecl, since the semantics are not actually described. But then, we should say that slice is semiregular or so. The pull request does the obvious thing, for now.)

@jensmaurer
Copy link
Member Author

@jwakely, please have a look.

jwakely
jwakely approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the minimal fix to make it consistent. Maybe we want another issue for your semiregular suggestion, but that might be a thread we don't want to start pulling in the ancient valarray wording.

@jensmaurer jensmaurer merged commit 8147026 into cplusplus:main May 4, 2022
@jensmaurer jensmaurer deleted the c70 branch May 4, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cons.slice] lists undeclared copy constructor
2 participants
@jensmaurer @jwakely