[stacktrace.basic.nonmem] Add missing \pnum before \recommended #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also augment check script
|
@jwakely , here you are. |
jwakely
reviewed
May 13, 2022
| @@ -11121,7 +11121,7 @@ | |||
| Once evaluation of \tcode{invoke(std::move(g), std::move(xyz))} begins, the function is no longer | |||
| considered deferred. | |||
|
|
|||
| \recommended | |||
| \recommended | |||
There was a problem hiding this comment.
Is this trick of adding a space before the macro documented anywhere as the correct way to use one without starting a new paragraph?
There was a problem hiding this comment.
No.
I've changed my check script so that it complains about \recommended (and similar introducers) without \pnum inside \itemdecl only. In the (rather exotic) case we have here, a \pnum isn't correct, because we're inside an \itemize environment. The space in front silences the check script. Maybe I should augment it even more so that stuff inside \itemize is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also augment check script
Fixes #5466