Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mem.poly.allocator.class.general] Specializations of polymorphic_allocator may need clarification #5468

Closed
frederick-vs-ja opened this issue May 16, 2022 · 3 comments · Fixed by #5470
Closed

[mem.poly.allocator.class.general] Specializations of polymorphic_allocator may need clarification #5468

frederick-vs-ja opened this issue May 16, 2022 · 3 comments · Fixed by #5470

Comments

@frederick-vs-ja
Copy link
Contributor

std::pmr::polymorphic_allocator<void> seems allowed currently, but it can't meet the Cpp17Allocator requirements. Should we say "A specialization of class template pmr​::​polymorphic_allocator meets the Cpp17Allocator requirements ([allocator.requirements.general]) if its template argument is a cv-unqualified object type."?

I'm not sure whether an LWG issue is needed as no practical change would be made.
@jensmaurer
Copy link
Member

@jwakely, any opinion here?

@jwakely
Copy link
Member

jwakely commented May 16, 2022

I like the suggestion. In the Networking TS, std::pmr::polymorphic_allocator<void> is a proto-allocator but we don't have that term in the IS. The suggestion seems like a good alternative fix.

@jwakely
Copy link
Member

jwakely commented May 16, 2022

And I agree this is just a clarification of the status quo, so editorial.

@frederick-vs-ja frederick-vs-ja mentioned this issue May 17, 2022
Merged
@frederick-vs-ja frederick-vs-ja mentioned this issue Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mem.poly.allocator.class.general] Clarify polymorphic_allocator<void> etc. frederick-vs-ja/draft
3 participants
@jwakely @frederick-vs-ja @jensmaurer