Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.join.view] Simplify range_reference_t<V> to InnerRng #5474

Merged
merged 1 commit into from May 19, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented May 19, 2022

I think this is a reasonable simplification and also makes it consistent with end().

I think this is a reasonable simplification and also makes it consistent with join_with_view.
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This seems to simply have been an oversight when we replaced the other occurrences with InnerRng.

@jensmaurer
Copy link
Member

@jwakely, this feels "obviously correct". What do you think?

@tkoeppe
Copy link
Contributor

tkoeppe commented May 19, 2022

Thanks!

@hewillk hewillk deleted the main-4 branch May 26, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants