Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[allocator.requirements.general] Simplify SimpleAllocator with some new styles #5482

Merged
merged 2 commits into from Aug 18, 2022
Merged

[allocator.requirements.general] Simplify SimpleAllocator with some new styles #5482

merged 2 commits into from Aug 18, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #5479.

@Dani-Hub
Copy link
Member

Shouldn't get allocate and deallocateget the same Tp -> T treatment?

@frederick-vs-ja
Copy link
Contributor Author

Shouldn't get allocate and deallocateget the same Tp -> T treatment?

@Dani-Hub Thank you for pointing the problem out! Now I'm fixing it.

jwakely
jwakely approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@tkoeppe tkoeppe merged commit 4db1d62 into cplusplus:main Aug 18, 2022
@frederick-vs-ja frederick-vs-ja deleted the simpler-ator-example branch August 22, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[allocator.requirements.general] Consider changing Example 2
4 participants
@frederick-vs-ja @Dani-Hub @jwakely @tkoeppe