[module.reach] Remove redundant module implementation unit declaration #5510
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this one when trying to implement [module.reach]. The problem here is that when the compiler see the module implementation unit declaration, the compiler would try to find the primary module interface. However, the primary module interface doesn't exist in the example.
Even we don't care the implementation details, it looks problematic from the perspective of language. According to [module.unit]p2 (https://eel.is/c++draft/module.unit#2):
But the example doesn't contain a primary module interface for module X and module B. So the example is problematic. Comparing to add the primary module interface, I think it is simpler to remove them simply.