[range.chunk] Add the class template description for chunk_view
#5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Add the class template description for chunk_view
This may not be an appropriate choice since this " |
|
The "for forward ranges" part is clarifying enough to me. And |
|
Please rebase? |
tkoeppe
added
the
needs rebase
|
@hewillk Ping ^^^ |
|
Is this acceptable? |
jensmaurer
removed
the
needs rebase
jensmaurer
approved these changes
Aug 20, 2022
|
The change itself looks good; the two commits should be squashed and force-pushed, and the commit description should be fixed. Something like "[range.chunk] Fix subclause headings" might work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I also removed the "
<V>" part in "Class templatechunk_view<V>::iteratorfor forward ranges" to be consistent with other sections.