Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.chunk.view.input] Add missing \exposid for base_ #5529

Merged
merged 2 commits into from Jun 15, 2022
Merged

[range.chunk.view.input] Add missing \exposid for base_ #5529

merged 2 commits into from Jun 15, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Jun 15, 2022

No description provided.

jwakely
jwakely reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only on base_ and not current_, remainder_ and n_ as well?

@hewillk
Copy link
Contributor Author

hewillk commented Jun 15, 2022

Sorry, I just got carried away by base_.

@jensmaurer jensmaurer merged commit 1bc1d28 into cplusplus:main Jun 15, 2022
@jensmaurer
Copy link
Member

Thanks.

@hewillk hewillk deleted the main-chunk branch June 16, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hewillk @jensmaurer @jwakely