Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space after \placeholder so can embed in code. #553

Merged
merged 1 commit into from Dec 10, 2015

Conversation

burblebee
Copy link
Contributor

No description provided.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 10, 2015

I see only two diffs in diffpdf, and in both cases this PR is an improvement. Example:

image

(The same would exist if one were to move the placeholder{} inside the code.)

With the PR:

image

@zygoloid
Copy link
Member

Are we somehow missing an italic correction after the R? We clearly had too much space beforehand, but it looks like slightly too little now. Anyway, as you say, this is an improvement.

zygoloid added a commit that referenced this pull request Dec 10, 2015
Remove space after \placeholder so can embed in code.
@zygoloid zygoloid merged commit ddf0f80 into master Dec 10, 2015
@zygoloid zygoloid deleted the placeholder-space-fixes branch December 10, 2015 01:17
@burblebee
Copy link
Contributor Author

On Wed, Dec 09, 2015 at 05:17:32PM -0800, Richard Smith wrote:

Are we somehow missing an italic correction after the R? We clearly had too much space beforehand, but it looks like slightly too little now. Anyway, as you say, this is an improvement.


Reply to this email directly or view it on GitHub:
#553 (comment)

To be honest, I made this change so long ago, I can't remember why I wanted it - I remember wanting to use it for something but not being able to because of this.. But I only just recently learned how to do "git pull"s for these things, and memory fades. Doh!

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 10, 2015

@zygoloid: Oddly enough, no permutation of \nocorr or \/ seems to have any effect on this.

It's different if we placed the placeholder inside the code, \tcode{foo_\placeholder{N}_bar}, but we're not doing that here.

@burblebee: I think the screenshot I pasted shows why you wanted this -- a good change. And keep the pull requests coming :-) (There are 200 issues waiting!)

@burblebee
Copy link
Contributor Author

On Thu, Dec 10, 2015 at 01:49:32AM -0800, Thomas Köppe wrote:

@burblebee: I think the screenshot I pasted shows why you wanted this -- a good change. And keep the pull requests coming :-)

Yeah, there was a case where I really wanted to use placeholder but couldn't because of the space. But by the time I got around to fixing placeholder I couldn't remember where that was anymore. Doh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants