Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use "named by" in place of "appear as" for odr-using a variable #5534

Merged
merged 3 commits into from Sep 8, 2022
Merged

use "named by" in place of "appear as" for odr-using a variable #5534

merged 3 commits into from Sep 8, 2022

Conversation

xmh0511
Copy link
Contributor

@xmh0511 xmh0511 commented Jun 17, 2022 •
edited by tkoeppe

Fixes #5533.

@xmh0511 xmh0511 mentioned this pull request Jun 17, 2022
Closed
jensmaurer
jensmaurer approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs squashing and a proper commit message.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 8, 2022

That much I can do.

@tkoeppe tkoeppe merged commit 20452e9 into cplusplus:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[basic.def.odr] p5 "appears as" is not defined and "named by" is a better choice
3 participants
@xmh0511 @tkoeppe @jensmaurer