[range.take.overview] Correct punctuation for take_view overview
#5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate name for take_view
jensmaurer
requested changes
Jul 13, 2022
Do you mean two pull requests or two commits? Maybe two pulls are the more appropriate option. |
|
I don't care. Pull requests essentially become irrelevant after their patches are merged. |
hewillk
changed the title
take_viewtake_view overview
|
I reverted the [ranges.syn] change since it's not technically "wrong", sorry for such unrelated tangled commit. |
jensmaurer
approved these changes
Jul 13, 2022
|
Thanks! Feel free to create a separate pull request for the other fix; consistency seems worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [ranges.syn], only the template list of
take_viewhas no name, so I added it for consistency.