Fix incorrect section reference as pointed out in LWG 2181 which beca… #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me not accepted during Kona meeting because of this being considered an editorial issue
| @@ -3187,7 +3187,7 @@ | |||
|
|
|||
| \pnum | |||
| Each type instantiated | |||
| from a class template specified in this section~\ref{rand.eng} | |||
There was a problem hiding this comment.
Why do we need a reference here at all?
|
The style to specify the concrete section makes the context clearer and we use this wording form in several places of the library. |
|
Makes sense, thanks. |
|
Could you please rename the commit message to include the section reference? |
|
Fixed at 45201e8 with a better commit message :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me not accepted during Kona meeting because of this being considered an editorial issue