[dcl.init.aggr]/1 Aggregate only cares about direct base classes CWG2610 #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Jul 22, 2022
jensmaurer
approved these changes
Aug 7, 2022
|
This looks good to me now. @hubert-reinterpretcast , please have a final look. |
It's good enough. I have a mild preference for repeating "virtual" and reordering the bullets so that the two "no private or protected" bullets are grouped together. |
Except for virtual ones
languagelawyer
force-pushed
the
patch-24
branch
from
c8af740
to
a0a2a3e
Compare
hubert-reinterpretcast
approved these changes
Aug 15, 2022
|
@jensmaurer Does CWG consider this editorial? (Feel free to merge if so!) |
jensmaurer
added
cwg
jensmaurer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cplusplus/CWG#101
See also #2892