[ranges.syn] Add \ref for ref_view
#5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Jul 26, 2022
There was a problem hiding this comment.
Looks mostly good.
Please change the commit description
[ranges.syn] Add template name for take_view
to say "... template parameter name..."
(Having two pull requests for these two unrelated changes would have allowed me to fix the commit description in the github GUI, easily).
|
Reverted the |
|
(oh, and force-pushing is fine for pull requests) |
hewillk
changed the title
ref_view and template name for take_viewref_view
jensmaurer
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.