Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concept.booleantestable] Remove unnecessary hyphenation hint for boolean-testable concept #5657

Merged
merged 2 commits into from Jul 27, 2022

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Jul 26, 2022

No description provided.

@@ -981,7 +981,7 @@
\tcode{true_type}\iref{meta.type.synop},
\tcode{int*}, and
\tcode{bitset<N>::reference}\iref{template.bitset}
model \exposconceptx{boolean\--testable}{boolean-testable}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this hyphenation hint is not needed anymore due to examples being a point smaller now.
1658856382
1658856392

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is two independent changes:

  • one noticing that the hyphenation hint is now superfluous
  • one noticing that a \placeholder should become an \exposconcept
    Two changes, two patches, please (two distinct pull requests are fine).

@hewillk hewillk changed the title [concept.booleantestable, concept.equalitycomparable] Use \exposconcept for exposition only concepts [concept.booleantestable] Remove unnecessary hyphenation hint for boolean-testable concept Jul 27, 2022
@jensmaurer jensmaurer merged commit 1033bad into cplusplus:main Jul 27, 2022
@hewillk hewillk deleted the main-concept branch July 29, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants