Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2022-07 LWG Motion 1] P2618R0 C++ Standard Library Issues #5667

Merged
merged 26 commits into from Aug 11, 2022
Merged

[2022-07 LWG Motion 1] P2618R0 C++ Standard Library Issues #5667

merged 26 commits into from Aug 11, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jul 28, 2022 •
edited by jensmaurer

@burblebee
Copy link
Contributor Author

The build is failing in check-output.sh because section depr.atomics.flag was removed by this paper (the failure is in the check for "Cross references since the previous standard."). How to make the build happy?

@Mick235711
Copy link
Contributor

Mick235711 commented Jul 28, 2022 •
edited

The build is failing in check-output.sh because section depr.atomics.flag was removed by this paper (the failure is in the check for "Cross references since the previous standard."). How to make the build happy?

I'm guessing add something like

\removedxref{depr.atomics.flag}

into xrefdelta.tex may satisfy the build script.

But again, I'm no expert in draft LaTeX usage, so I'm not sure if this will fix it or not. Yeah, this fixed the error.

jwakely
jwakely reviewed Jul 28, 2022
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
jwakely
jwakely reviewed Jul 28, 2022
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
jwakely
jwakely reviewed Jul 28, 2022
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
jwakely
jwakely reviewed Jul 28, 2022
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
jwakely
jwakely reviewed Jul 28, 2022
View reviewed changes
source/threads.tex Outdated Show resolved Hide resolved
jwakely
jwakely requested changes Jul 28, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one error in the content, a couple of formatting problems, and a couple of no-op changes to simplify the LaTeX.

@jensmaurer jensmaurer added this to the post-2022-07 milestone Jul 28, 2022
@burblebee burblebee requested a review from jwakely July 28, 2022 21:53
jwakely
jwakely approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks

@burblebee @tkoeppe
LWG3564 transform_view::iterator<true>::value_type and iterator_categ…
0472487 
…ory should use const F&
@burblebee @tkoeppe
LWG3617 function/packaged_task deduction guides and deducing this
c5b6a5c
@burblebee @tkoeppe
LWG3656 Inconsistent bit operations returning a count
53c83cf
@burblebee @tkoeppe
LWG3659 Consider ATOMIC_FLAG_INIT undeprecation
c61c1b6
@burblebee @tkoeppe
LWG3670 Cpp17InputIterators don't have integer-class difference types
6fbded2
@burblebee @tkoeppe
LWG3671 atomic_fetch_xor missing from stdatomic.h
50f1e24
@burblebee @tkoeppe
LWG3672 common_iterator::operator->() should return by value
0df9a20
@burblebee @tkoeppe
LWG3683 operator== for polymorphic_allocator cannot deduce template a…
da4456d 
…rgument in common cases
@burblebee @tkoeppe
LWG3687 expected<cv void, E> move constructor should move
29f66da
@burblebee @tkoeppe
LWG3692 zip_view::iterator's operator<=> is overconstrained
76a86b8
@burblebee @tkoeppe
LWG3701 Make formatter<remove_cvref_t<const charT[N]>, charT> require…
62e3587 
…ment explicit
@burblebee @tkoeppe
LWG3702 Should zip_transform_view::iterator remove operator<?
d29b963
@burblebee @tkoeppe
LWG3703 Missing requirements for expected<T, E> requires is_void<T>
62fe2a0
@burblebee @tkoeppe
LWG3704 LWG 2059 added overloads that might be ill-formed for sets
a7cbca7
@burblebee @tkoeppe
LWG3705 Hashability shouldn't depend on basic_string's allocator
f8f6265
@burblebee @tkoeppe
LWG3707 chunk_view::outer-iterator::value_type::size should return un…
7ecb746 
…signed type
@burblebee @tkoeppe
LWG3708 take_while_view::sentinel's conversion constructor should move
d6a68e3
@burblebee @tkoeppe
LWG3709 LWG-3703 was underly ambitious
60fa43a
@tkoeppe tkoeppe merged commit 6cce010 into main Aug 11, 2022
@jensmaurer jensmaurer deleted the motions-2022-07-lwg-1 branch November 18, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@tkoeppe tkoeppe tkoeppe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2022-07
5 participants
@burblebee @Mick235711 @jwakely @tkoeppe @jensmaurer