Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[futures.async] Use code font for "std::async" #570

Merged
merged 1 commit into from Dec 18, 2015
Merged

[futures.async] Use code font for "std::async" #570

merged 1 commit into from Dec 18, 2015

Conversation

K-ballo
Copy link
Contributor

@K-ballo K-ballo commented Nov 22, 2015

No description provided.

@sigfpe
Copy link

sigfpe commented Nov 22, 2015

Why is unqualified async an editorial change?-------- Original message --------From: Agustín Bergé notifications@github.com Date: 11/21/2015 5:00 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Subject: [draft] [futures.async] Replace "std::async" with "async" in code
font (#570)

You can view, comment on, or merge this pull request online at:
  #570

Commit Summary

[futures.async] Replace "std::async" with "async" in code font

File Changes

M
source/threads.tex
(2)

Patch Links:

https://github.com/cplusplus/draft/pull/570.patch
https://github.com/cplusplus/draft/pull/570.diff


Reply to this email directly or view it on GitHub.

@K-ballo
Copy link
Contributor Author

K-ballo commented Nov 22, 2015

Why is unqualified async an editorial change?

Because of 17.6.1.1 [contents]/3, but even without that simply because it is a note.

@sigfpe
Copy link

sigfpe commented Nov 22, 2015

Thanks. Notes aren't normative, but we want to keep them confusion-free.-------- Original message --------From: Agustín Bergé notifications@github.com Date: 11/21/2015 6:00 PM (GMT-08:00) To: cplusplus/draft draft@noreply.github.com Cc: sigfpe sig.fpe@axiomatics.org Subject: Re: [draft] [futures.async] Replace "std::async" with "async" in code
font (#570)

Why is unqualified async an editorial change?

Because of 17.6.1.1 [contents]/3, but even without that simply because it is a note.


Reply to this email directly or view it on GitHub.

@jwakely
Copy link
Member

jwakely commented Dec 16, 2015

Using code font is correct. Normally I would say that the qualification is redundant because of 17.6.1.1, but in this case it does help avoid confusion between the function template std::async and the enumerator std::launch::async ... but in fact the destructor won't block if the launch::deferred policy is chosen, so arguably the note could be changed to refer to launch::async not the function template!

But as written, where it refers to the function template, I think disambiguating with the qualification is useful.

@K-ballo K-ballo changed the title [futures.async] Replace "std::async" with "async" in code font [futures.async] Use code font for "std::async" Dec 16, 2015
jwakely added a commit that referenced this pull request Dec 18, 2015
[futures.async] Use code font for "std::async"
@jwakely jwakely merged commit 8875b64 into cplusplus:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants