Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2286R8 Formatting Ranges #5700

Merged
merged 8 commits into from Aug 16, 2022
Merged

P2286R8 Formatting Ranges #5700

merged 8 commits into from Aug 16, 2022

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Aug 3, 2022

Fixes #5601

The paper adds examples which contain non-ascii characters. I wasn't able to figure out how to add these examples and needed to delete them in order to fix the build.

@burblebee burblebee marked this pull request as ready for review August 3, 2022 05:04
@burblebee burblebee added the decision-required A decision of the editorial group (or the Project Editor) is required. label Aug 3, 2022
source/utilities.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from jwakely August 3, 2022 21:33
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Show resolved Hide resolved
source/utilities.tex Show resolved Hide resolved
source/utilities.tex Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Show resolved Hide resolved
source/containers.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from jwakely August 5, 2022 04:46
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One editorial rearrangement suggested for the synopsis, one formatting change for the Unicode categories, and the issue with quotes as part of the literal or not that needs a decision.
And Corentin's changes for the Unicode strings, in #5702

@burblebee burblebee requested a review from jwakely August 5, 2022 19:53
@burblebee
Copy link
Contributor Author

burblebee commented Aug 5, 2022

... And Corentin's changes for the Unicode strings, in #5702

#5702 is failing the build because of the non-ascii chars. I'll leave the "decision required" label on for what to do about the missing examples.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 14, 2022

Note to self: Apply pending changes from motions LWG-5 and -6 (flat*{map,set}) here.

@tkoeppe tkoeppe force-pushed the motions-2022-07-lwg-14 branch 2 times, most recently from 609776d to 6374706 Compare August 16, 2022 12:56
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 16, 2022

One editorial rearrangement suggested for the synopsis, one formatting change for the Unicode categories, and the issue with quotes as part of the literal or not that needs a decision. And Corentin's changes for the Unicode strings, in #5702

@cor3ntin, @jwakely: is there still an unresolved issue regarding "quotes as part of the literal"?

@tkoeppe tkoeppe removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Aug 16, 2022
@tkoeppe tkoeppe merged commit 1cb566e into main Aug 16, 2022
@JohelEGP
Copy link
Contributor

Also resolves cplusplus/papers#977.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 16, 2022

Thanks!

@jwakely
Copy link
Member

jwakely commented Sep 9, 2022

@cor3ntin, @jwakely: is there still an unresolved issue regarding "quotes as part of the literal"?

Sorry, I missed this ping. No, that got resolved.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 9, 2022

Great, thank you for checking!

@jensmaurer jensmaurer deleted the motions-2022-07-lwg-14 branch July 23, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2022-07 LWG Motion 14] P2286R8 Formatting Ranges
8 participants