[strings.general,thread.general] Remove nonexistent header and fix some style error #5703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
approved these changes
Aug 4, 2022
jensmaurer
requested changes
Aug 4, 2022
Done. |
|
In the commit description, I'm not seeing what "and fix some style error" would refer to for the second commit. It now exclusively removes a non-existing header from the intro table. |
That part of the message is for adding a comma. The rendered draft looks like |
jensmaurer
approved these changes
Aug 12, 2022
|
I'll take this and fix up the commit messages -- thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[strings.general]: Add
<string>to the String classes subclause[thread.general]: Remove nonexistent header
<atomic_ref>and add a comma.