Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2585R1 Improving default container formatting #5706

Merged
merged 2 commits into from Aug 18, 2022
Merged

Conversation

burblebee
Copy link
Contributor

Fixes #5624

Based on P2286R8 Formatting Ranges in branch motions-2022-07-lwg-14

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 4, 2022

Shouldn't this be merged into said branch, rather than main? Like other motion PRs that modify existing motions.

source/utilities.tex Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
@burblebee burblebee force-pushed the motions-2022-07-lwg-37 branch 2 times, most recently from 500aeb4 to d05a9b1 Compare August 5, 2022 19:23
source/utilities.tex Outdated Show resolved Hide resolved
@burblebee burblebee force-pushed the motions-2022-07-lwg-37 branch 2 times, most recently from 73a0bd2 to a2bee27 Compare August 5, 2022 20:55
@burblebee burblebee marked this pull request as ready for review August 5, 2022 20:59
@jensmaurer jensmaurer added this to the post-2022-07 milestone Aug 5, 2022
@burblebee
Copy link
Contributor Author

Shouldn't this be merged into said branch, rather than main? Like other motion PRs that modify existing motions.

Hopefully it's clear how to apply this. The edits were rebased on top of motions-2022-07-lwg-14, so once motions-2022-07-lwg-14 is merged, this pr can be rebased and merged. There should only be two commits to apply:

  • P2585R1 Improving default container formatting [258cfea]
  • [format.range.formatter] Rename constructor to match renamed struct [a2bee27]

burblebee and others added 2 commits August 18, 2022 14:07
Editorial changes:
* Constructors have been renamed from "formatter" to
  "range-default-formatter" to match the renaming of the class.
The original, large subclause contained several class template
synopses without any intervening separation. The header synopsis is
rearranged to follow the document order.
@tkoeppe tkoeppe merged commit 973f8f1 into main Aug 18, 2022
@JohelEGP
Copy link
Contributor

Also resolves cplusplus/papers#1244.

@jensmaurer jensmaurer deleted the motions-2022-07-lwg-37 branch November 18, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2022-07 LWG Motion 37] P2585R1 Improving default container formatting
5 participants